Skip to content

fix(opencode): ensure help output ends with newline#28643

Closed
xmh1011 wants to merge 1 commit into
anomalyco:devfrom
xmh1011:fix/help-newline-readme-typo-28606
Closed

fix(opencode): ensure help output ends with newline#28643
xmh1011 wants to merge 1 commit into
anomalyco:devfrom
xmh1011:fix/help-newline-readme-typo-28606

Conversation

@xmh1011

@xmh1011 xmh1011 commented May 21, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #28606
Closes #26114
Closes #27485

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

opencode --help can print yargs help text without a trailing newline, which leaves the next shell prompt on the same line as the final help option. This updates the shared show() helper to append one platform newline only when the generated help text does not already end with \n.

The PR also adds regression coverage for top-level help and documented command help output so future CLI help paths keep the trailing newline while preserving the existing help snapshots. Separately, it fixes the whenver typo in the dev control-plane README.

How did you verify your code works?

  • npx -y bun@1.3.14 test test/cli/help/help-snapshots.test.ts --timeout 180000
  • npx -y bun@1.3.14 typecheck

Screenshots / recordings

N/A - terminal output and documentation-only changes.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label May 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate PRs Found

I found two related PRs that appear to be addressing the same issue:

  1. PR fix(cli): add newline to help output #28622 - fix(cli): add newline to help output

  2. PR fix: add trailing newline to help output #26374 - fix: add trailing newline to help output

Why they're related: All three PRs (including the current PR #28643) are specifically addressing the issue of ensuring help output ends with a newline character. PR #28622 appears to be the most recent similar attempt with nearly identical scope to the current PR.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label May 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant